fix: assign product quantities by id match instead of index in addNew…#113
Open
ZIADMOHAMED-A8 wants to merge 1 commit into
Open
fix: assign product quantities by id match instead of index in addNew…#113ZIADMOHAMED-A8 wants to merge 1 commit into
ZIADMOHAMED-A8 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: Wrong quantities assigned to products in addNewCart
Problem
When adding a cart, product quantities were being assigned by index after filtering from frozenData.products. Since filter returns products in their stored order rather than the order they were passed in the request, the quantities were mismatched — e.g. sending {id:6, qty:1}, {id:4, qty:3} would result in id:6 getting qty:3 and id:4 getting qty:1.
Fix
Instead of relying on index to match quantities, we now use productIds.indexOf(p.id) to look up the correct quantity for each product by its id, regardless of the order products are returned from the data store.